adding rsockets support into JDK
yingqi.lu at intel.com
Sat Nov 17 18:47:11 UTC 2018
I already updated the version 17 of the patch at http://cr.openjdk.java.net/~ylu/8195160.17/. I also updated the apidoc at http://cr.openjdk.java.net/~ylu/rsocket_apidoc/jdk.net/jdk/net/package-summary.html and the zip file attached to the CSR.
I changed the CSR https://bugs.openjdk.java.net/browse/JDK-8205186 to “FINIALIZED” status.
Only thing missing now is that I cannot remove specdiffs that Brian uploaded. I do not have access either. Brian, can you please help here?
From: Alan Bateman [mailto:Alan.Bateman at oracle.com]
Sent: Saturday, November 17, 2018 1:18 AM
To: Lu, Yingqi <yingqi.lu at intel.com>; Chris Hegarty <chris.hegarty at oracle.com>
Cc: nio-dev at openjdk.java.net; Viswanathan, Sandhya <sandhya.viswanathan at intel.com>; Aundhe, Shirish <shirish.aundhe at intel.com>; Kaczmarek, Eric <eric.kaczmarek at intel.com>
Subject: Re: adding rsockets support into JDK
On 16/11/2018 17:28, Lu, Yingqi wrote:
I have updated the CSR https://bugs.openjdk.java.net/browse/JDK-8205186
1. I added the link to Javadoc files for jdk.net
2. I also zip the same rsocket_api folder and attached to the CSR
3. I updated the CSR content with finalized class names and function names
Please review and let me know if everything looks OK.
The spec looks good. Just one minor comment - the final paragraph of the class description has a link to ExtendedSocketOptions which isn't interesting for RDMA sockets. One suggestion is drop the entire paragraph because the RDMA specific socket option don't any permission checks.
I added myself as Reviewer to the CSR and I see Chris has done this too So I think you should be able to finalize. It would be good if we could remove the specdiffs attachment that Brian has a few weeks ago as it's not in sync with the latest javadoc. I tried to remove it but I don't have access.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the nio-dev