adding rsockets support into JDK
chris.hegarty at oracle.com
Mon Nov 19 18:17:14 UTC 2018
On 19/11/18 17:25, Lu, Yingqi wrote:
> Hi Alan/Chris/Brian,
> Thank you very much for your help on finalizing the CSR. Really appreciate!
> I modified JEP accordingly at
> The most recent version of the patch is available at
Still reviewing, some passing comments:
I don't think that the `opens java.net to jdk.net` is still needed.
- The changes in src/jdk.net/share/classes/jdk/net/Sockets.java can be
- The tests all follow a pattern similar to the following:
, which is fine. More recently we've been preferring to throw a jtreg
specific exception to indicate that the test was skipped, rather than
run. The exception is jtreg.SkippedException. For example look at the
usage in PromiscuousIPv6 .
- Must the tests be run with `-Djava.net.preferIPv4Stack=true` ? I
understand that IPv6 is not supported in the rsocket implementation,
but just curious if the system property is strictly needed?
More information about the nio-dev