adding rsockets support into JDK

Chris Hegarty chris.hegarty at
Mon Nov 19 18:17:14 UTC 2018

On 19/11/18 17:25, Lu, Yingqi wrote:
> Hi Alan/Chris/Brian,
> Thank you very much for your help on finalizing the CSR. Really appreciate!
> I modified JEP accordingly at 
> The most recent version of the patch is available at 
> <>

Still reviewing, some passing comments:

- src/java.base/share/classes/
   I don't think that the `opens to` is still needed.

- The changes in src/ can be

- The tests all follow a pattern similar to the following:

     if (!RsocketTest.isRsocketAvailable())

   , which is fine. More recently we've been preferring to throw a jtreg
   specific exception to indicate that the test was skipped, rather than
   run. The exception is jtreg.SkippedException. For example look at the
   usage in PromiscuousIPv6 [1].

- Must the tests be run with `` ? I
   understand that IPv6 is not supported in the rsocket implementation,
   but just curious if the system property is strictly needed?



More information about the nio-dev mailing list