adding rsockets support into JDK
Alan.Bateman at oracle.com
Fri Nov 30 08:43:20 UTC 2018
On 30/11/2018 06:07, Lu, Yingqi wrote:
> Hi All,
> I updated version 21 of the patch at http://cr.openjdk.java.net/~ylu/8195160.21/. Javadoc is available at http://cr.openjdk.java.net/~ylu/rsocket_docs/api/jdk.net/module-summary.html
You've addressed my comments in the javadoc so they look good.
I see you've added a sentence "If the specified protocol family ..." in
response to Chris's comment. I don't think we strictly need this in the
javadoc as it relates to how subsequent calls to bind or connect behave
and those methods already specify how they handle unsupported address
types. If you want to keep wording in the factory methods then it will
need a few changes to keep is simple. A suggestion for penSocketChannel is:
"When binding the channel's socket to a local address, or invoking
connect to connect channel's socket, the socket address specified to
those methods must correspond to the protocol family specified here".
This deliberately leaves out any mention of IAE or UATE as they are
specified by the bind/connect methods.
One other minor comment is in the class description where it says that
the selector provider does not support datagram channels. Can we expand
this to " and pipes. The openDatagramChannel and openPipe methods throw
UOE". This goes back to the mails earlier this year on using the
provider() method to get the to a degraded selector provider. We can
live with these openXXX methods throwing UOE.
More information about the nio-dev