adding rsockets support into JDK
yingqi.lu at intel.com
Fri Nov 30 16:08:13 UTC 2018
I have already updated the CSR at https://bugs.openjdk.java.net/browse/JDK-8205186
The Javadoc link inside the CSR has already updated with updated content.
I also reattached the updated zip file of the doc.
Please let me know if there is anything still missing.
>From: Chris Hegarty [mailto:chris.hegarty at oracle.com]
>Sent: Friday, November 30, 2018 4:36 AM
>To: Alan Bateman <Alan.Bateman at oracle.com>; Lu, Yingqi
><yingqi.lu at intel.com>
>Cc: Viswanathan, Sandhya <sandhya.viswanathan at intel.com>; nio-
>dev at openjdk.java.net; Aundhe, Shirish <shirish.aundhe at intel.com>;
>Kaczmarek, Eric <eric.kaczmarek at intel.com>
>Subject: Re: adding rsockets support into JDK
>On 30/11/2018 08:43, Alan Bateman wrote:
>> On 30/11/2018 06:07, Lu, Yingqi wrote:
>>> Hi All,
>>> I updated version 21 of the patch at
>>> http://cr.openjdk.java.net/~ylu/8195160.21/. Javadoc is available at
>> You've addressed my comments in the javadoc so they look good.
>> I see you've added a sentence "If the specified protocol family ..."
>> in response to Chris's comment. I don't think we strictly need this in
>> the javadoc as it relates to how subsequent calls to bind or connect
>> behave and those methods already specify how they handle unsupported
>> address types. If you want to keep wording in the factory methods then
>> it will need a few changes to keep is simple. A suggestion for
>> "When binding the channel's socket to a local address, or invoking
>> connect to connect channel's socket, the socket address specified to
>> those methods must correspond to the protocol family specified here".
>This wording is good.
>I requested this note since these sockets / channels will be the first such, that
>when created with an INET6 family will disallow IPv4 addressing. While not
>strictly required, I think it is good to call this out clearly.
>For example DatagramChannel does not do this:
>jshell> var dc = DatagramChannel.open(StandardProtocolFamily.INET6)
>dc ==> sun.nio.ch.DatagramChannelImpl at 7e774085
>jshell> var addr = Inet6Address.getByName("127.0.0.1")
>addr ==> /127.0.0.1
>jshell> dc.bind(new InetSocketAddress(addr, 0))
>$10 ==> sun.nio.ch.DatagramChannelImpl at 7e774085
>P.S. I'm still working through the remainder of the webrev, but I think the
>specification in RdmaSockets and RdmaSocketOptions is good, subject to the
>aforementioned comments. Please update the CSR and I will re-review it.
More information about the nio-dev