adding rsockets support into JDK

Lu, Yingqi at
Fri Nov 30 17:19:08 UTC 2018

Hi Chris,

Thanks very much for the help! 

I fully understand that the timeline for JDK12 is very tight. Given there are still two weeks till Dec.13th deadline for code integration, I would like still give it a try and see how far we can make. If yes, great. If not, we can trunk the code as soon as it is ready. Then JDK13 will be the target :-) For CSR, we can set the target to 13 for now.

Does this sound reasonable?


>-----Original Message-----
>From: Chris Hegarty [mailto:chris.hegarty at]
>Sent: Friday, November 30, 2018 8:54 AM
>To: Lu, Yingqi < at>
>Cc: Alan Bateman <Alan.Bateman at>; Viswanathan, Sandhya
><sandhya.viswanathan at>; nio-dev at; Aundhe,
>Shirish <shirish.aundhe at>; Kaczmarek, Eric
><eric.kaczmarek at>
>Subject: Re: adding rsockets support into JDK
>> On 30 Nov 2018, at 16:08, Lu, Yingqi < at> wrote:
>> Hi Chris,
>> I have already updated the CSR at
>The CSR looks good to me. I have re-added myself as a reviewer.
>The CSR can now be (re-)finalised, but first it will need a `Fix Version` set, to
>indicate the target JDK release. Given the close proximity to JDK 12 RDP 1 [1], I
>can only suggest that the fix version be se to `13`, since code review is ongoing
>and the JEP yet to be Proposed To Target.  I have code review comments yet
>to be sent, I'm just trying to get them into a reasonable form.

More information about the nio-dev mailing list