adding rsockets support into JDK
brian.burkhalter at oracle.com
Tue Oct 2 22:19:09 UTC 2018
A few minor comments.
RdmaPollSelectorImpl - The imported “Unsafe” is not used. In general any unused imports and #includes should be removed.
LinuxRdmaSocketDispatcherImpl.preClose0() - The native function eventually invoked is empty. Perhaps LinuxRdmaSocketDispatcherImpl.preClose() could just be made a no-op and preClose0() removed?
RdmaNet.isRdmaAvailable0() - Commented-out lines 59-61 should be deleted.
Otherwise, I ran this through our build and test system and there were no issues with version 12.
On Sep 29, 2018, at 8:59 PM, Lu, Yingqi <yingqi.lu at intel.com> wrote:
> Please find version 12 of the patch available at http://cr.openjdk.java.net/~ylu/8195160.12. I tested on my local Linux machine without any RDMA devices. The issue with the two test cases is resolved. Please review and let me know if you see anything else is missing.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the nio-dev