adding rsockets support into JDK
yingqi.lu at intel.com
Wed Oct 3 23:42:25 UTC 2018
Here is the version 13 of the patch. http://cr.openjdk.java.net/~ylu/8195160.13
In this version, I fixed the items you mentioned in your previous email.
In addition, I went through all the files and removed additional imports/#includes.
I also extended the Copyright year range to 2018 on the changed files. For all the newly added files especially test cases, I did "Copyright (c) 2018" even though some of content are copied from other regular socket or socket channel related test cases. Please let me know if this is the right way to do it.
From: Brian Burkhalter [mailto:brian.burkhalter at oracle.com]
Sent: Tuesday, October 2, 2018 3:19 PM
To: Lu, Yingqi <yingqi.lu at intel.com>
Cc: Aundhe, Shirish <shirish.aundhe at intel.com>; nio-dev at openjdk.java.net; Viswanathan, Sandhya <sandhya.viswanathan at intel.com>; Kaczmarek, Eric <eric.kaczmarek at intel.com>
Subject: Re: adding rsockets support into JDK
A few minor comments.
RdmaPollSelectorImpl - The imported "Unsafe" is not used. In general any unused imports and #includes should be removed.
LinuxRdmaSocketDispatcherImpl.preClose0() - The native function eventually invoked is empty. Perhaps LinuxRdmaSocketDispatcherImpl.preClose() could just be made a no-op and preClose0() removed?
RdmaNet.isRdmaAvailable0() - Commented-out lines 59-61 should be deleted.
Otherwise, I ran this through our build and test system and there were no issues with version 12.
On Sep 29, 2018, at 8:59 PM, Lu, Yingqi <yingqi.lu at intel.com<mailto:yingqi.lu at intel.com>> wrote:
Please find version 12 of the patch available at http://cr.openjdk.java.net/~ylu/8195160.12. I tested on my local Linux machine without any RDMA devices. The issue with the two test cases is resolved. Please review and let me know if you see anything else is missing.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the nio-dev