adding rsockets support into JDK

Lu, Yingqi at
Thu Oct 4 00:02:08 UTC 2018

Hi Brian,

Thank you for all the help here!

I also modified the CSR at by adding following lines to the end of it. I think we need to include all the API changes here?

In addition, we will change the access modifier on the following methods: ServerSocket(SocketImpl impl) from package private to protected setSocket(Socket soc) and setServerSocket(ServerSocket soc) from package private to protected

Please review and let me know if there is anything missing.


From: Brian Burkhalter [mailto:brian.burkhalter at]
Sent: Wednesday, October 3, 2018 4:45 PM
To: Lu, Yingqi < at>
Cc: Aundhe, Shirish <shirish.aundhe at>; nio-dev at; Viswanathan, Sandhya <sandhya.viswanathan at>; Kaczmarek, Eric <eric.kaczmarek at>
Subject: Re: adding rsockets support into JDK

Hi Lucy,

On Oct 3, 2018, at 4:42 PM, Lu, Yingqi < at< at>> wrote:

Here is the version 13 of the patch.

Thanks, I’ll take a look.

In this version, I fixed the items you mentioned in your previous email.

In addition, I went through all the files and removed additional imports/#includes.

Sounds good.

I also extended the Copyright year range to 2018 on the changed files. For all the newly added files especially test cases, I did “Copyright (c) 2018” even though some of content are copied from other regular socket or socket channel related test cases. Please let me know if this is the right way to do it.

That seems fine to me.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the nio-dev mailing list