adding rsockets support into JDK
yingqi.lu at intel.com
Thu Oct 4 00:02:08 UTC 2018
Thank you for all the help here!
I also modified the CSR at https://bugs.openjdk.java.net/browse/JDK-8205186 by adding following lines to the end of it. I think we need to include all the API changes here?
In addition, we will change the access modifier on the following methods:
java.net.ServerSocket: ServerSocket(SocketImpl impl) from package private to protected
java.net.SocketImpl: setSocket(Socket soc) and setServerSocket(ServerSocket soc) from package private to protected
Please review and let me know if there is anything missing.
From: Brian Burkhalter [mailto:brian.burkhalter at oracle.com]
Sent: Wednesday, October 3, 2018 4:45 PM
To: Lu, Yingqi <yingqi.lu at intel.com>
Cc: Aundhe, Shirish <shirish.aundhe at intel.com>; nio-dev at openjdk.java.net; Viswanathan, Sandhya <sandhya.viswanathan at intel.com>; Kaczmarek, Eric <eric.kaczmarek at intel.com>
Subject: Re: adding rsockets support into JDK
On Oct 3, 2018, at 4:42 PM, Lu, Yingqi <yingqi.lu at intel.com<mailto:yingqi.lu at intel.com>> wrote:
Here is the version 13 of the patch. http://cr.openjdk.java.net/~ylu/8195160.13
Thanks, I’ll take a look.
In this version, I fixed the items you mentioned in your previous email.
In addition, I went through all the files and removed additional imports/#includes.
I also extended the Copyright year range to 2018 on the changed files. For all the newly added files especially test cases, I did “Copyright (c) 2018” even though some of content are copied from other regular socket or socket channel related test cases. Please let me know if this is the right way to do it.
That seems fine to me.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the nio-dev