adding rsockets support into JDK

Lu, Yingqi at
Fri Oct 26 20:19:21 UTC 2018

Hi Brian,

Thank you very much for the help reviewing the APIs. I already made the changes accordingly.

Have you got any chance to look at the test cases? I plan to wait for your feedback there and send out the webrev version 15 with all the changes.


From: Brian Burkhalter [mailto:brian.burkhalter at]
Sent: Friday, October 26, 2018 12:02 PM
To: Lu, Yingqi < at>
Cc: Aundhe, Shirish <shirish.aundhe at>; nio-dev at; Viswanathan, Sandhya <sandhya.viswanathan at>; Kaczmarek, Eric <eric.kaczmarek at>
Subject: Re: adding rsockets support into JDK

Hi Lucy,

For now, just a few minor points regarding the API verbiage.


474: I think “server-socket” should have the hyphen removed: “server socket”.


67, 80, 93: Should it say “bound or connected” instead of simply “bound”?
69, 82, 95: “RDMA based -> “RDMA-based” (add a hyphen)
69, 82, 95: I don’t think that RdmaSocketImpl should be mentioned in the javadoc as it is not in the public API.



On Oct 5, 2018, at 8:23 PM, Lu, Yingqi < at< at>> wrote:

The link is updated with the additional file It might be just me, but I needed to refresh both pages and to get the updated content.

Please let me know if you see any issues.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the nio-dev mailing list