8220477: Channels.newWriter() does not close if underlying channel throws an IOException

Brian Burkhalter brian.burkhalter at oracle.com
Fri Mar 29 14:34:20 UTC 2019

> On Mar 29, 2019, at 12:35 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> On 28/03/2019 21:29, Brian Burkhalter wrote:
>> For the issue [1] please review the proposed patch [2]. The change is to catch an IOException thrown by implClose() and mark the {en,de}coder as closed anyway. Lots of lines of test for a small change!
> Looks good. As you are there, would you mind fixing formatting in StreamDecoder? I can't tell what happened to it but it looks like the intendation has been removed from L230+ onwards (I only noticed it when looking at the implClose at the end of file).

Yes I can fix that.

After I posted this RFR, I ran the patch through all the testing tiers and with this patch the test


fails at line 50. I need to think whether this indicates a problem with the patch or the StreamEncoderClose test is incorrect.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190329/bc9cee56/attachment.html>

More information about the nio-dev mailing list