RFR[8235783]: DatagramSocket::disconnect should allow an implementation to throw UncheckedIOException

Chris Hegarty chris.hegarty at oracle.com
Fri Jan 10 16:17:17 UTC 2020


> On 10 Jan 2020, at 15:26, Patrick Concannon <patrick.concannon at oracle.com> wrote:
> Hi Alan,
> Thanks for the feedback.
> I've incorporated your comments into the webrev below.
> http://cr.openjdk.java.net/~pconcannon/8235783/webrevs/webrev.01/

Mostly looks good. A few small comments:

1) "If this **channel’s** socket is not bound then ...” - please remove “channel’s"

2) Maybe start the text of the new throws clauses with lowercase - which seems to be the existing style


More information about the nio-dev mailing list