<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <p><br>
    </p>
    <br>
    <div class="moz-cite-prefix">On 2018/7/19 4:30 PM, Alan Bateman
      wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:589e321a-f2ef-b33a-c638-27b5249550d9@oracle.com">
      <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
      <br>
      <br>
      <div class="moz-cite-prefix">On 19/07/2018 09:20, Hamlin Li wrote:<br>
      </div>
      <blockquote type="cite"
        cite="mid:81a23717-9052-1dd4-08bf-9a68d95c1891@oracle.com">
        <meta http-equiv="Content-Type" content="text/html;
          charset=utf-8">
        <p>I think it's better to have Utils.adjustTimeout, remember
          this issue is reported because of "<span style="color: rgb(51,
            51, 51); font-family: Arial, sans-serif; font-size: 14px;
            font-style: normal; font-variant-ligatures: normal;
            font-variant-caps: normal; font-weight: 400; letter-spacing:
            normal; orphans: 2; text-align: start; text-indent: 0px;
            text-transform: none; white-space: normal; widows: 2;
            word-spacing: 0px; -webkit-text-stroke-width: 0px;
            background-color: rgb(255, 255, 255); text-decoration-style:
            initial; text-decoration-color: initial; display: inline
            !important; float: none;"><span> </span>select took 5204 ms</span>",
          it could take longer than that. so I think we'd better to
          scale select timeout according to jtreg timeout factor.<br>
        </p>
        <blockquote type="cite"
          cite="mid:32047075-b726-d61d-0385-80eecc08c767@oracle.com">I
          think the solution to this issue is a one-line fix - either
          drop the assert (as it's not useful here) or change it to just
          check that select didn't complete immediately. <br>
        </blockquote>
        Sure, I think so too, will drop the assert.<br>
        <br>
        patch is updated in place: <a class="moz-txt-link-freetext"
          href="http://cr.openjdk.java.net/%7Emli/8207244/webrev.00/"
          moz-do-not-send="true">http://cr.openjdk.java.net/~mli/8207244/webrev.00/</a><br>
      </blockquote>
      Dropping the assert is fine but the use of adjustTimeout doesn't
      make sense here. testInterruptDuringSelect is testing that
      interrupting select or a timed select does not close the Selector,
      the timeout isn't important is not nothing to do with timeout
      factor specified to jtreg.<br>
    </blockquote>
    Got it, thank you for explanation, I have updated the change in
    place.<br>
    <br>
    -Hamlin<br>
    <blockquote type="cite"
      cite="mid:589e321a-f2ef-b33a-c638-27b5249550d9@oracle.com"> <br>
      -Alan<br>
    </blockquote>
    <br>
  </body>
</html>