<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div class=""><br class=""></div><div class="">Looks good. A few comments:</div><div class=""><br class=""></div><div class="">* src/share/classes/sun/misc/Unsafe.java</div><div class=""><br class=""></div><div class="">javadoc for copySwapMemory says “@since 9” which seems confusing at best.</div><div class=""><br class=""></div><div class="">The original change in jdk9 only added the new methods to the jdk internal Unsafe, while this back port adds them to sun.misc.Unsafe. I’ll leave it for somebody else to comment on the appropriateness of that.</div><div class=""><br class=""></div><div class="">* CopySwap.java test</div><div class=""><br class=""></div><div class="">You’ll probably want to back port the test covered by <a href="https://bugs.openjdk.java.net/browse/JDK-8149611" class="">https://bugs.openjdk.java.net/browse/JDK-8149611</a> as well. It was supposed to go in together with the fix.</div><div class=""><br class=""></div><div class="">Cheers,</div><div class="">Mikael</div><div><br class=""><blockquote type="cite" class=""><div class="">On Nov 7, 2018, at 9:45 AM, David Buck <<a href="mailto:david.buck@oracle.com" class="">david.buck@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Hi!<br class=""><br class="">May I please get a review of this straightforward backport from JDK 9 to JDK 8:<br class=""><br class="">bug report:<br class=""><a href="https://bugs.openjdk.java.net/browse/JDK-8141491" class="">https://bugs.openjdk.java.net/browse/JDK-8141491</a><br class=""><br class="">JDK 9 change sets:<br class="">http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/75f6573e9c44<br class="">http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/13759d57abca<br class=""><br class="">JDK 9 review thread:<br class="">http://mail.openjdk.java.net/pipermail/nio-dev/2015-November/003365.html<br class="">http://mail.openjdk.java.net/pipermail/nio-dev/2016-January/003496.html<br class="">http://mail.openjdk.java.net/pipermail/nio-dev/2016-February/003522.html<br class=""><br class="">JDK 8 webrevs (for review):<br class="">http://cr.openjdk.java.net/~dbuck/8141491_jdk8_ver00/<br class=""><br class="">The backport is almost line-for-line the same as the JDK 9 fix with the following exceptions:<br class=""><br class="">- assertions / guarantees need to have their format strings wrapped with err_msg() [0]<br class=""><br class="">- there is no need to "backout" of JDK-8140630 [1], which was never backported to JDK 8 in the first place.<br class=""><br class="">This fix is urgently needed for JDK 8 built with newer versions of GCC.<br class=""><br class="">Cheers,<br class="">-Buck<br class=""><br class="">[0] https://bugs.openjdk.java.net/browse/JDK-8080775<br class="">[1] https://bugs.openjdk.java.net/browse/JDK-8140630<br class=""></div></div></blockquote></div><br class=""></body></html>