request for API change approval: ObservableSet
richard.bair at oracle.com
Thu Dec 8 11:52:53 PST 2011
Cool. Can you create a new patch with the latest proposal and attach it to the JIRA issue?
On Dec 8, 2011, at 2:14 AM, Martin Soch wrote:
> Hi Richard,
> after discussion with Martin Sladecek he suggested to remove ObservableSetWrapper from public API so it will be consistent for now.
> On 12/08/2011 10:08 AM, Martin Soch wrote:
>> Hi Richard,
>> thanks for your comments.
>> - public wrappers: Martin Sladecek is recently (in a separate request)
>> moving wrapper classes to the javafx.collection package as well; I don't
>> know the motivation behind but Michael Heinrichs (on CC) might know more
>> - var-arg factory method: will add it unless anyone has any objections
>> On 12/07/2011 08:09 PM, Richard Bair wrote:
>>> Hi Martin,
>>> Generally I would suggest that we move this conversation to the
>>> openjfx-dev mailing list. I'm wanting to start moving as many of these
>>> sorts of design approval requests there as we can.
>>> However, my first thoughts:
>>> - Yay!
>>> - Why is ObservableSetWrapper public? We don't have any other Wrappers
>>> for the other collections public, do we? Are we sure we want to do
>>> this now?
>>> - I would suggest adding a var-args factory method to FXCollections
>>> for creating a set, as well as a Collections version for convenience
>>> Otherwise looks consistent with our other Observable collections as
>>> far as I can see.
>>> On Dec 7, 2011, at 7:00 AM, Martin Soch wrote:
>>>> Hi team,
>>>> I would like to ask you for approval for a new API to be pushed to
>>>> 2.1 repository. This new API is adding ObservableSet interface into
>>>> javafx.collection package with basic wrapper implementation. This
>>>> change is not modifying any current API; just adding new functionality.
>>>> JIRA: http://javafx-jira.kenai.com/browse/RT-14664
>>>> WebRev: http://javame-linux.cz.oracle.com/r/1334/
More information about the openjfx-dev