Review request for RT-19228
richard.bair at oracle.com
Fri Mar 30 09:37:42 PDT 2012
I can understand the impatience but really there needs to be an affirmative answer before an API addition / change is made.
It would be helpful to have a condensed description of the final solution with reasons behind it. I didn't just give it an immediate +1 because the final solution is OK but not what I had hoped for, and introducing a new syntax / special fx:attribute is kind of a bummer. These are still my favorites:
<TableView columnResizePolicy="CONSTRAINED_RESIZE_POLICY" />
<TableView columnResizePolicy="TableView.CONSTRAINED_RESIZE_POLICY" />
But it seems they were rejected because the implementation isn't well positioned to support it -- which seems backwards. It seems that the nicer syntax should be the primary driver and the implementation to adjust to fit it. It would be nice to have a good argument for why we ought to do fx:constant instead of any of the originally proposed options.
For example, I don't understand this comment:
"what if we did this:
That would be more consistent with existing syntax (particularly fx:factory), and also wouldn't conflict with syntax for attached properties. "
How does this conflict with attached properties to not have fx:constant?
On Mar 30, 2012, at 8:02 AM, Greg Brown wrote:
> Since no one has commented on this, I will assume that there are no concerns and will mark this issue as fixed.
> On Mar 28, 2012, at 6:38 PM, Greg Brown wrote:
>> I have not received any comments on this. Does anyone have any questions or suggestions?
>> On Mar 20, 2012, at 12:52 PM, Greg Brown wrote:
>>> This change adds support for an "fx:constant" attribute that will resolve to the value of a constant (static final variable) defined by the associated element's type. For example:
>>> <columnResizePolicy><TableView fx:constant="CONSTRAINED_RESIZE_POLICY"/></columnResizePolicy>
>>> It parallels the fx:value and fx:factory attributes, which are used to invoke a static valueOf() method and an a static factory method on the target type, respectively.
More information about the openjfx-dev