Anybody looking for a quick patch to contribute?
phidias51 at gmail.com
Wed Mar 13 10:24:21 PDT 2013
I know you guys are busily opening up JavaFX, and I was wondering if there
has been any effort to clean up the code? Not trying to critique the code,
but some of the earlier code I saw wouldn't have passed minimal checkstyle
I recently had to delve into LineChart, and there were a number of missing
comments on public methods, unnecessary "inheritDocs" tags on overridden
methods, funky approaches to iterating through series data that only work
within the charts package (can't be used by anyone extending the class),
variables like "createSymbols" which are actually anonymous inner classes
rather than a simple property.
Also, do your automated builds run FindBugs or similar tools periodically?
That might also help identify some problem spots before they escape out
into the wild.
Hmm. Well, I guess I did end up critiquing the code. When the code review
tools come on line it will be easier to give you guys direct feedback on
the classes, instead of heckling from the sidelines. :-)
On Wed, Mar 13, 2013 at 9:57 AM, Richard Bair <richard.bair at oracle.com>wrote:
> > Is there a plan to eventually integration this code into the OpenJDK 8
> > tree (like nashorn, for instance)?
> Not for a long time, probably Java 9 time at the earliest.
> >> I'm guessing you are on Linux? I have worked out windows & mac, about
> >> to start on the linux build. I'm guessing it dies on building native
> >> code?
> > It seems that it fails with the :graphics:effects-jsl:compileBlend task.
> I just pushed a fix to graphics scrum and it compiles now for me on Linux.
> > But maybe I'm just doing something here, I'm not much of a gradle expert
> > yet.
> No, I'm just still fixing the gradle build, it isn't ready for production
> > One final question, what other code is still needed to be open sourced?
> > I guess we're mostly done, right?
> We're getting close!
More information about the openjfx-dev