Anybody looking for a quick patch to contribute?

Tom Schindl tom.schindl at
Wed Mar 13 16:05:48 PDT 2013

Am 13.03.13 18:24, schrieb Mark Fortner:
> Hi Richard,
> I know you guys are busily opening up JavaFX, and I was wondering if there
> has been any effort to clean up the code? Not trying to critique the code,
> but some of the earlier code I saw wouldn't have passed minimal checkstyle
> settings.

I cleaned up already some parts of the control classes - Jonathan
applied fairly all patches, I provided. It is a bit cumbersome because
we are still not allowed to attach patches to JIRA.

> I recently had to delve into LineChart, and there were a number of missing
> comments on public methods, unnecessary "inheritDocs" tags on overridden
> methods, funky approaches to iterating through series data that only work
> within the charts package (can't be used by anyone extending the class),
> variables like "createSymbols" which are actually anonymous inner classes
> rather than a simple property.

There's is already a discussion between Richard and me why inner-classes
are used when there is Simple*Property available in the mailing list
archive. It is a trading between static (inner-classes) and dynamic
footprint (Simple*Property)


B e s t S o l u t i o n . a t                        EDV Systemhaus GmbH
tom schindl                 geschäftsführer/CEO
eduard-bodem-gasse 5-7/1   A-6020 innsbruck     fax      ++43 512 935833                      phone    ++43 512 935834

More information about the openjfx-dev mailing list