[8u] Review request: RT-38290: [WebView] HTML canvas clip() functionality broken
Anton V. Tarasov
anton.tarasov at oracle.com
Wed Aug 27 06:38:09 UTC 2014
Sure, thanks for the reminder.
On 27.08.2014 1:11, Stephen F Northover wrote:
> Hi Anton T,
> The policy for OpenJFX is that code reviews happen in the associated JIRA:
> Thanks for reviewing this code,
> On 2014-08-26, 3:30 PM, Anton V. Tarasov wrote:
>> Hi Anton,
>> Does it make sense to add a boolean param to renderLayer() which would tell it if it should
>> dispose the layer after rendering? In order to avoid the splitting.
>> Also, could you please clarify the following.
>> From your comments:
>> 72 // WCBufferedContext might be referenced from a client JS code and thus
>> 73 // couldn't be disposed right after rendering operations on it.
>> However, when it is disposed (will it?) it looks like it will re-render all the layers
>> (WCGraphicsPrismContext.dispose). Is it an expected behavior?
>> On 8/20/14 9:26 PM, anton nashatyrev wrote:
>>> could you please review the fix for https://javafx-jira.kenai.com/browse/RT-38290 ?
>>> Thank you!
More information about the openjfx-dev