review: Refactoring KeyEvent.getKeyCodeForChar
David.Hill at Oracle.com
Wed Jun 11 15:59:05 UTC 2014
Kevin, Steve, Anthony,
Webrev for the refactor is here: http://cr.openjdk.java.net/~ddhill/RT-37492/ <http://cr.openjdk.java.net/%7Eddhill/RT-37492/>
A simple test application is attached. I tested by running it against the before and then the after build on Linux and ARM checking the code returns are the same.
Windows, Mac, IOS are hopefully right as this is a pretty easy substitution.
I did notice that a few SWT did not have a native impl of the call currently ..... those I fixed that using the pattern, but still will be missing the native impl.
David Hill <David.Hill at Oracle.com>
Java Embedded Development
"We trained hard, but it seemed that every time we were beginning
to form up into teams, we would be reorganized. I was to learn later
in life that we tend to meet any new situation by reorganizing;
and a wonderful method it can be for creating the illusion of progress
while producing confusion, inefficiency, and demoralization."
-- Unknown (misattributed to Petronius Arbiter, 210AD).
More information about the openjfx-dev