Review request for 8169294:
james.graham at oracle.com
Mon Nov 7 20:05:12 UTC 2016
I'd like to see Kevin review the test as I'm not the best expert on our
It looks like it is mostly just going to emit some printouts about
performance (using echo() and log()) and verify that we don't get any
ArrayBounds related exceptions (or worse, OOME)?
The only difference in Path2D.java I noted is that the Java2D version
has an EXPAND_MIN which is 10, but you re-use INIT_SIZE, which is 20,
here for the same purpose.
I think that's fine, but wanted to point it out so you could comment...
On 11/6/2016 1:01 PM, Laurent Bourgès wrote:
> Please review this Path2D fix improving its storage growth algorithm as
> done in java2d:
> JBS: https://bugs.openjdk.java.net/browse/JDK-8169294
> Webrev: http://cr.openjdk.java.net/~lbourges/fx/path2D/
> PS: I converted the former jtreg test to JUnit test for OpenJFX. I hope
> it is correct, as I was not able to run this test within gradle (but it
> works in netbeans)
> Best regards,
More information about the openjfx-dev