Fwd: Re: Marlin-Renderer and JavaFX

Laurent Bourgès bourges.laurent at gmail.com
Mon Nov 7 22:55:02 UTC 2016


Here is the new patch:

- cleanup wrt OpenJDK9 (Unsafe is OK but I switch to the standard Cleaner)
- modified PrismSettings as recommended and renamed all Marlin properties
to use the prefix 'prism.marlin'
- SWContext: added Marlin SW support: I had to tweak the processed range[x;
pix_to[ instead of [pix_from; pix_to[ as the PiscesRenderer does not handle
properly the bbox so it processes many extra pixels on the left side (empty
coverage) = to be discussed as it can be fixed in the native prism-sw code
... See my comment in the code:

+            @Override+            public void
setAndClearRelativeAlphas(final int[] alphaDeltas, final int pix_y,+
                                               final int pix_from,
final int pix_to)+            {+                // use x instead of
pix_from as it cause artefacts:+                // note: it would be
more efficient to skip all those empty pixels [x to pix_from[+
       // but the native implementation must be fixed too.+//
      pr.emitAndClearAlphaRow(alpha_map, alphaDeltas, pix_y, pix_from,
pix_to, rowNum);+                pr.emitAndClearAlphaRow(alpha_map,
alphaDeltas, pix_y, x, pix_to, rowNum);

I successfully built OpenJFX9 (gradle) and tested OK with OpenJDK9 b143
(xpatch.args) with Ensemble8 + DemoFX.

Maybe it is time to start the review for the FX enhancement ?


2016-11-04 19:55 GMT+01:00 Jim Graham <james.graham at oracle.com>:

> On 11/4/2016 11:33 AM, Laurent Bourgès wrote:
>> For SWContext, I figured out that only openpisces.* classes were used
>> directly via imports (hardcoded) so I left it unchanged. So you propose
>> to generalize use of marlin or native pisces ?
> I didn't notice that, I was just searching on the use of
> "doNativePisces".  We can look at that separately, and Kevin would know how
> frequently we end up in the SW pipeline these days...

More information about the openjfx-dev mailing list