Fwd: Re: Marlin-Renderer and JavaFX

Laurent Bourgès bourges.laurent at gmail.com
Thu Nov 10 13:35:49 UTC 2016


2016-11-10 0:47 GMT+01:00 Jim Graham <james.graham at oracle.com>:

> Hi Laurent,
> Great job on creating a very obvious minimal impact!  That should help
> streamline it through the approval process.


> Is MarlinProperties.isEnabled still used?  (Searching patch file - no, I
> don't think so)

Will fix and also remove all tile related properties.

> Kevin and I had a long back and forth over the packaging of the Reentrant
> files and came up with "com.sun.util.reentrant" as we'd like to avoid
> "com.sun" as a terminal package.  We should eventually move a few other
> common utilities into that new tree as well, but we can start with these
> classes.


> I still want to take a pass through the changes to the Marlin files
> themselves, but above is my review of the glue code and with that Kevin can
> pursue the internal processes.
> Before I pursue too far on reading the Marlin source changes, I'd like to
> hear back about how this version of Marlin(FX) differs from the OpenJDK
> version of Marlin(2D) - were they based on different versions of your
> Marlin project?  Also, you mentioned waiting for the jigsaw build patch
> integration.  I'm guessing you meant the build changes that happened
> yesterday, so we can proceed now?

About jigsaw integration: I made the latest patch (JBS) after testing a
complete OpenJDK9+OpenJFX9 build and running DemoFX + Ensemble8.

Yes, let's discuss the webrev on a dedicated thread:

> With respect to the changes to the native part of the SW pipeline that
> would trim the rendering - please continue to investigate them, but we
> should pursue those as a separate bug fix so as not to complicate this
> particular change.  It sounds like you've adapted the new code in the
> SWContext wrapper class to not require that native change yet, so let's go
> with that for the first phase...

Agreed, let's postpone that effort later as it is not blocking.


More information about the openjfx-dev mailing list