[9] Review request: 8178015: Clarify requirement for app modules to export/open packages to javafx modules

Kevin Rushforth kevin.rushforth at oracle.com
Fri Apr 21 23:08:51 UTC 2017

OK, so you recommend changing module-info.class to module-info.java and 
removing the reference to Module#addExports entirely, right? I can fix 
this as part of a general cleanup JBS issue [1] that is left open to 
pick up various typos, etc.

Would you recommend the same for the FXML annotation, and not refer them 
to Module#addOpens?

-- Kevin

[1] https://bugs.openjdk.java.net/browse/JDK-8177341

Alex Buckley wrote:
> On 4/20/2017 11:06 AM, Kevin Rushforth wrote:
>> Additionally, I removed the example in the FXML annotation showing the
>> use of "opens to" in module-info.java (but left the example in
>> Application).
> Similar to my private comments to you on a related matter:
> Recommend straightforwardness: "... the module must export (or open) 
> the containing package to at least the javafx.graphics module. [NEW 
> PARAGRAPH] For example, ..."
> I don't get the desire to always rotate towards module-info._class_ 
> and Module#addExports when the focus should be on ordinary source code.
> Alex

More information about the openjfx-dev mailing list