MarlinFX upgrade 0.7.5
bourges.laurent at gmail.com
Wed Apr 26 21:37:19 UTC 2017
2017-04-26 7:06 GMT+02:00 Jim Graham <james.graham at oracle.com>:
> I've reviewed the code and run a number of tests. Things look fine.
Thanks, but as I made some syntax changes in Marlin2D, I would like to
postpone the review and synchronize again the code with Marlin2D.
> I spotted at least one thing that I brought up in the 2D Marlin review,
> but since the 2 source bases are moving towards synchronizing with each
> other I didn't look too closely since many of the changes in the 2D Marlin
> update are things that are already "fixed" in this FX Marlin code, so I
> thought I would focus my scrutiny more on the 2D review instead. Would this
> code base be affected by the review comments I made there? Did you want to
> hold both until they both are ready to go in and then push them at the same
> time (to keep them in sync)?
I really do not know how to push both patches at the same time as it points
to different forrests ... (I only have commit rights in graphics repo ?)
Probably I let you push the final patches once ready and I will also
maintain my github branches in sync.
> Minimally, it is time to file a bug against FX for this...
> On 4/19/17 11:35 PM, Laurent Bourgès wrote:
>> Please review this MarlinFX upgrade to Marlin 0.7.5:
>> JBS: no bug yet for OpenJFX 10
>> webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-075.0/
>> - Renderers: fixed block processing
>> - dead code & few comment removals in Strokers
>> - fixed all floating-point number literals to be x.0f or x.0d to simplify
>> the conversion between float & double variants
>> PS: I plan to run later FindBugs, Netbeans & IntelliJ code analysis tools
>> to fix any warning
More information about the openjfx-dev