[9] Review request: 8170702: Document that javafx.graphics needs explicit access to application main class

Mandy Chung mandy.chung at oracle.com
Sat Mar 4 00:17:31 UTC 2017

> On Mar 3, 2017, at 10:36 PM, Kevin Rushforth <kevin.rushforth at oracle.com> wrote:
> [fixed subject line]
> Please review the following to document that javafx.graphics needs explicit access to the Application class.
> https://bugs.openjdk.java.net/browse/JDK-8170702
> http://cr.openjdk.java.net/~kcr/8170702/webrev.00/

  69  * containing package must be {@link Module#isExported(String,Module) exported}

@linkplain instead?

 239         StackTraceElement[] cause = Thread.currentThread().getStackTrace();

Good candidate to use StackWalker API.

Is @throws RuntimeException an existing behavior?  I’d think CNFE and InaccessibleAE might be more appropriate.

line 209 “It must be a subclass of Application or a RuntimeException will be thrown.”

I think this statement should be extended to cover if the class and its constructor are public and exported.


More information about the openjfx-dev mailing list