RFR: 8214119: Update to 607.1 version of WebKit

Murali Billa murali.billa at oracle.com
Wed Dec 19 16:33:08 UTC 2018

Looks fine.
One minor observation: 

WCFontImpl.java -> Regarding   log.fine(String.format("str='%s' length=%d", str, str.length()));, I see earlier code which followed below format for ‘length’
log.fine(String.format("str='%s' (length=%d)", str, str.length()));

-----Original Message-----
From: Kevin Rushforth 
Sent: Wednesday, December 19, 2018 7:01 PM
To: Arunprasad Rajkumar <arunprasad.rajkumar at oracle.com>; Murali Billa <murali.billa at oracle.com>; Johan Vos <johan.vos at gluonhq.com>; Joeri Sykora <joeri.sykora at gluonhq.com>
Cc: Praveen Srivastava <praveen.s.srivastava at oracle.com>; Victor D'yakov <victor.dyakov at oracle.com>; openjfx-dev at openjdk.java.net List <openjfx-dev at openjdk.java.net>
Subject: Re: RFR: 8214119: Update to 607.1 version of WebKit

Looks good to me.


-- Kevin

On 12/18/2018 10:16 AM, Arunprasad Rajkumar wrote:
> Hi Kevin, Murali, Johan, Joeri,
> Please review the following patch which merges GTK WebKit 2.22(607.1) into jfx-dev:
> http://cr.openjdk.java.net/~arajkumar/8214119/webrev
> Above link has a webrev and a changeset file,
> 1. rt-non-native-webkit — Contains changes other than "modules/javafx.web/src/main/native", it will be useful _only_ for review, don’t apply the patch from it.
> 2. rt.changeset.gz — Actual changeset file in compressed format which contains all the changes from “rt” directory(including WebKit native changes), uncompress before using it(gunzip rt.changeset.gz) and do the following steps.,
> $ hg clone http://hg.openjdk.java.net/openjfx/jfx-dev/rt
> $ cd rt
> $ hg import --no-commit rt.changeset #(from rt.changset.gz)
> This changeset requires the following versions of toolchains to build properly,
> * MSVC- 2017-15.5.5 or higher on Windows
> * GCC 7.3.0 or higher on Linux
> * Xcode 9.4 or higher on MacOS
> Thanks,
> Arun

More information about the openjfx-dev mailing list