RFR: 8234174: Change IDEA VCS mapping to Git

Kevin Rushforth kcr at openjdk.org
Thu Nov 14 15:06:07 UTC 2019

On Thu, 14 Nov 2019 14:35:26 GMT, Alexander Scherbatiy <alexsch at openjdk.org> wrote:

> Allow IDEA to correctly detect Git version control system when opening JFX project.
> ----------------
> Commits:
>  - f0f1866a: 8234174: Change IDEA VCS mapping to Git
> Changes: https://git.openjdk.java.net/jfx/pull/37/files
>  Webrev: https://webrevs.openjdk.java.net/jfx/37/webrev.00
>   Issue: https://bugs.openjdk.java.net/browse/JDK-8234174
>   Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
>   Patch: https://git.openjdk.java.net/jfx/pull/37.diff
>   Fetch: git fetch https://git.openjdk.java.net/jfx pull/37/head:pull/37

Adding to what @tsayao said, there is a JBS issue, [JDK-8223373](https://bugs.openjdk.java.net/browse/JDK-8223373), to remove the `.idea` files from the repo.

I think this change is fine in the short term even if we end up removing the .idea files in the near future.

.idea/vcs.xml line 8:

Minor: can you restore the newline that was removed? It isn't related to the change, and in general, text files should end with a newline (although that's a suggestion, not a rule).

PR: https://git.openjdk.java.net/jfx/pull/37

More information about the openjfx-dev mailing list