RFR: 8217472: Add attenuation for PointLight

Nir Lisker nlisker at openjdk.org
Mon Nov 18 18:00:46 UTC 2019

On Mon, 18 Nov 2019 18:00:45 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
> ----------------
> Commits:
>  - a388fb92: Fixed whitespaces
>  - 415927e6: Correction for indexes
>  - 3450ffe9: Docs and year update
>  - 4b63a01f: Merge remote-tracking branch 'nlisker/8217472_Add_attenuation_for_PointLight' into 8217472_Add_attenuation_for_PointLight
>  - 52e1ae1a: Separate range from attenuation
>  - d39bceeb: GL pipeline
>  - a590f09a: Initial push of 8217472
> Changes: https://git.openjdk.java.net/jfx/pull/43/files
>  Webrev: https://webrevs.openjdk.java.net/jfx/43/webrev.00
>   Issue: https://bugs.openjdk.java.net/browse/JDK-8217472
>   Stats: 498 lines in 27 files changed: 385 ins; 13 del; 100 mod
>   Patch: https://git.openjdk.java.net/jfx/pull/43.diff
>   Fetch: git fetch https://git.openjdk.java.net/jfx pull/43/head:pull/43

Tested D3D on Win 10 and GL on Ubuntu 18.04.

There is still a bug (at least on Win) for some certain combinations of values as shown in this picture:

This sample program can be used to test the changes.
Controls: mouse wheel zooms, RMB drag rotates, LMB pans.


Kevin, Ambarish,

You can start the review, especially the API. I will hunt that specific values bug this week.

I'll need to know what kind of tests are needed in terms of functionality and performance.

PR: https://git.openjdk.java.net/jfx/pull/43

More information about the openjfx-dev mailing list