RFR: 8253356: JavaFX Terminology Refresh

Kevin Rushforth kcr at openjdk.java.net
Wed Dec 16 13:20:23 UTC 2020

On Wed, 16 Dec 2020 12:35:34 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Replace archaic/non-inclusive words in JavaFX with more neutral terms. See [JDK-8253315](https://bugs.openjdk.java.net/browse/JDK-8253315) for background information.
>> The following changes are made:
>> 1. Rename whitelist/blacklist to allowlist/rejectlist
>> 2. Rename `MasterTimer` to `PrimaryTimer` in animation and toolkit implementation
>> 3. Rename local variable master in a couple places
>> 4. Remove master from comments in a few other places
>> This PR doesn't remove uses of the word master where there is no connotation of slavery.
>> Note that it is out of scope of this PR to address similar issues in 3rd-party code, such as WebKit or GStreamer. We will pick up any relevant changes after they are available in the upstream sources.
> `modules\javafx.graphics\src\main\native-glass\ios\GlassWindow.h`  has declaration of variables named `masterWindow` and `masterWindowHost`.
> Please check if we should change these too.

Yes, I agree that these should be changed as well. Given the following in `GlassWindow.h`:

+(GlassMainWindow *)  getMasterWindow;

changing `masterWindow` to `mainWindow` is a better fit anyway.


PR: https://git.openjdk.java.net/jfx/pull/368

More information about the openjfx-dev mailing list