RFR: 8258592: Control labels in Dialogs are truncated at certain DPI scaling levels

Kevin Rushforth kcr at openjdk.java.net
Thu Dec 17 16:36:56 UTC 2020

On Thu, 17 Dec 2020 15:55:58 GMT, Jose Pereda <jpereda at openjdk.org> wrote:

> This PR is a follow up of [JDK-8199592](https://bugs.openjdk.java.net/browse/JDK-8199592). 
> When using DPI scaling levels > 1, labels of controls get truncated when they are added to Dialogs which have an owner Window. 
> To fix the issue, this PR binds dialog and owner window renderScale X, Y properties.
> It also provides a system test that can be tested on Linux and Windows. Before applying the fix, the `Check` text of the checkboxes is rendered as `Che...`. With the fix, the test verifies, for a given UI scale, that the rendered text is `Check` when launching the dialog.

Looks good. This seems a straight-forward enough fix that a single review would suffice.

I left one question on the cleanup method in the test, but it's up to you as to whether to address it.

tests/system/src/test/java/test/javafx/scene/UIRenderDialogTest.java line 121:

> 119:     public static void teardown() {
> 120:         Platform.runLater(() -> {
> 121:             alert.hide();

Maybe add a null check in case the test fails to create the Alert?


Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/369

More information about the openjfx-dev mailing list