RFR: 8255572: Axis does not compute preferred height properly when autoRanging is off [v4]

Jonathan Vusich github.com+31666175+jonathanvusich at openjdk.java.net
Tue Dec 22 14:54:12 UTC 2020

> As noted in the corresponding JBS issue, `Axis` does not properly compute its preferred height when `autoRanging` is turned off. The simplest fix seems to be changing `CategoryAxis` so that `tickLabelRotation` is set to 90 degrees if there is not enough room for the category labels to layout horizontally. This fixes the fact that the axis labels are truncated and also ensures that the chart does not leave unused space from the layout calculations. `CategoryAxis` is already setting the `categorySpacing` property when `autoRanging` is off, so this seems to be an appropriate fix.

Jonathan Vusich has updated the pull request incrementally with one additional commit since the last revision:

  Remove unused import


  - all: https://git.openjdk.java.net/jfx/pull/342/files
  - new: https://git.openjdk.java.net/jfx/pull/342/files/6d83f79c..0d11d341

 - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=342&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=342&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.java.net/jfx/pull/342.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/342/head:pull/342

PR: https://git.openjdk.java.net/jfx/pull/342

More information about the openjfx-dev mailing list