RFR: 8255572: Axis does not compute preferred height properly when autoRanging is off [v4]

Kevin Rushforth kcr at openjdk.java.net
Thu Dec 24 00:35:56 UTC 2020

On Wed, 25 Nov 2020 15:56:05 GMT, Jonathan Vusich <github.com+31666175+JonathanVusich at openjdk.org> wrote:

>> While this does fix the specific problem, it introduces a new one. If the labels are initially too big, but after resizing the window would now fit, it does not recompute the orientation. This means that you are left with labels that are rotated even when they don't need to be.
> @kevinrushforth Thank you for catching that. Do you think it would be acceptable to simply rotate the labels back to zero if the user expands the window?

The fix seems fine to me. I recommend also adding a test for a vertical axis.


PR: https://git.openjdk.java.net/jfx/pull/342

More information about the openjfx-dev mailing list