[Rev 02] RFR: 8237469: Inherited styles don't update when node is moved

Kevin Rushforth kcr at openjdk.java.net
Wed Feb 5 00:14:15 UTC 2020

On Wed, 5 Feb 2020 00:14:15 GMT, Dean Wookey <dwookey at openjdk.org> wrote:

>> Everything passes with the fix and 5 of the new tests fail without the fix.
>> removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest
>> movingBranchToDifferentBranchGetsNewCssVariableTest
>> removingThenAddingNodeToDifferentBranchGetsCorrectInheritedValue
>> removingThenAddingNodeToDifferentBranchGetsIneritableStyle
>> movingNodeToDifferentBranchGetsNewFontStyleTest
>> I doubt this will cause a significant performance decrease. I think it's worth it for correctness. The only other thing is that I kept the fix to the minimum, but technically canReuseHelper now has a side effect. I could try rewrite some things if necessary, or maybe rename the method? Else leave it as is?
>> Originally introduced here: https://bugs.openjdk.java.net/browse/JDK-8090462/ https://github.com/openjdk/jfx/commit/834b0d05e7a2a8351403ec4a121eab312d80fd24#diff-9ec098280fa1aeed53c70243347e76ab
> The pull request has been updated with 1 additional commit.

This looks good to me. I appreciate all of the added unit tests. I also confirmed that this fixed [JDK-8234877](https://bugs.openjdk.java.net/browse/JDK-8234877), so I will close that one as a duplicate.

This is now ready to integrate. Either Ajit or I can sponsor it.


Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/87

More information about the openjfx-dev mailing list