[Rev 01] RFR: 8235772: Remove use of deprecated finalize method from PiscesRenderer and AbstractSurface

Ambarish Rapte arapte at openjdk.java.net
Mon Feb 10 13:33:41 UTC 2020

On Fri, 7 Feb 2020 18:36:18 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> `AbstractSurface.nativePtr` is needed to create the `AbstractSurfaceDisposerRecord`.
>> It is created and set by the native method `initialize(dataType, width, height);` invoked at line 45 in the `JavaSurface` constructor.
>> It is the reason `addDisposerRecord()` is needed here.
> Oh, I see. The native initialize method in the subclass is writing into a private field in the superclass. Can you add a comment to this effect, since it isn't obvious without reading the native code?

The comment would be really helpful for readers.


PR: https://git.openjdk.java.net/jfx/pull/66

More information about the openjfx-dev mailing list