RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation

Jeanette Winzenburg fastegal at openjdk.java.net
Fri Feb 14 11:24:10 UTC 2020

On Fri, 14 Feb 2020 09:09:13 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
> Fix : Added the missed out RTL checks to the key mappings in TableViewBehaviorBase class.
> Testing : Modified unit tests in TableViewKeyInputTest to take orientation as a parameter. The Left/Right key press tests have been modified to address LTR and RTL orientations.
> Note : If this test modification is acceptable, I would like to address other similar tests separately. (I will create a test JBS issue and address later)

modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TableViewBehaviorBase.java line 139:

> 138:         boolean rtl = isRTL();
> 139: 
> 140:         KeyMapping enterKeyActivateMapping, escapeKeyCancelEditMapping;

node orientation can change during the lifetime of a node ...


PR: https://git.openjdk.java.net/jfx/pull/114

More information about the openjfx-dev mailing list