RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation
kcr at openjdk.java.net
Fri Feb 14 14:08:36 UTC 2020
On Fri, 14 Feb 2020 11:26:14 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:
>> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
>> Fix : Added the missed out RTL checks to the key mappings in TableViewBehaviorBase class.
>> Testing : Modified unit tests in TableViewKeyInputTest to take orientation as a parameter. The Left/Right key press tests have been modified to address LTR and RTL orientations.
>> Note : If this test modification is acceptable, I would like to address other similar tests separately. (I will create a test JBS issue and address later)
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TableViewBehaviorBase.java line 152:
>> 152: new KeyMapping(LEFT, (rtl? e -> selectRightCell() : e -> selectLeftCell())),
>> 153: new KeyMapping(KP_LEFT, (rtl? e -> selectRightCell() : e -> selectLeftCell())),
> ... so a keyMapping based on the initial condition will fail after a change of orientation, or what am I missing?
> (aside: I really hate this review ui, can't seem to make it take several comments ... argghh)
To add multiple comments, go to the `Files changed` tab and click on a line of code to add a comment there. Select `Start a review` rather than `Add single comment`. This way you can batch up multiple comments. Then you select `Finish Review` in the upper right.
More information about the openjfx-dev