RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation

Kevin Rushforth kcr at openjdk.java.net
Sat Feb 15 15:03:59 UTC 2020

On Fri, 14 Feb 2020 09:09:13 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
> Fix : Added the missed out RTL checks to the key mappings in TableViewBehaviorBase class.
> Testing : Modified unit tests in TableViewKeyInputTest to take orientation as a parameter. The Left/Right key press tests have been modified to address LTR and RTL orientations.
> Note : If this test modification is acceptable, I would like to address other similar tests separately. (I will create a test JBS issue and address later)

@kleopatra is right about the need to handle the case where the orientation of a node changes. As for the test, I think the idea of parameterizing it with LTR, RTL is good. I haven't reviewed it in detail, but added one minor suggestion for you to consider.

modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewKeyInputTest.java line 102:

> 101: 
> 102:     private NodeOrientation orientation;
> 103: 

I might recommend also adding a `private boolean ltr` instance variable to make the check less verbose, but that's up to you.


PR: https://git.openjdk.java.net/jfx/pull/114

More information about the openjfx-dev mailing list