RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation

Kevin Rushforth kcr at openjdk.java.net
Sat Feb 15 15:04:00 UTC 2020

On Fri, 14 Feb 2020 14:27:15 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> To add multiple comments, go to the `Files changed` tab and click on a line of code to add a comment there. Select `Start a review` rather than `Add single comment`. This way you can batch up multiple comments. Then you select `Finish Review` in the upper right.
> thanks, Kevin - that's what I tried, but it refused to accept the second .. so sticking with single comments until I feel like digging into this weirdness.

Regarding the fix, it seems that you need to eliminate the `rtl` variable you added earlier, and move the test into the listener, like this:

    new KeyMapping(LEFT, e -> isRtl() ? selectRightCell() : selectLeftCell()),


PR: https://git.openjdk.java.net/jfx/pull/114

More information about the openjfx-dev mailing list