RFR: 8239454: LLIntData : invalid opcode returned for 16 and 32 bit wide instructions
kcr at openjdk.java.net
Wed Feb 19 16:58:35 UTC 2020
On Wed, 19 Feb 2020 12:09:50 GMT, Arun Joseph <ajoseph at openjdk.org> wrote:
> With new bytecode format introduced in Webkit 608.1, the unlinked and linked bytecodes were replaced by narrow (1-byte operand) and wide (4-byte operand) bytecodes. These were extended to narrow, wide16 and wide32 bytecodes in WebKit 609.1. In narrow instructions, each argument of the opcode has a fixed size of 1-byte. The same applies for wide 16 and wide32 with 2-byte and 4-byte, respectively.
> Bug: When `getOpcodeWide(id)` is called in `LLIntData.h`, the value (`id` - `numOpcodesIDs`) is returned.
> Fix: It's modified to (`id` + `numOpcodesIDs`) in `getOpcodeWide16()` and (`id` + `numOpcodesIDs`*2) in `getOpcodeWide32()`.
Fix looks good. Testing looks good.
Marked as reviewed by kcr (Lead).
More information about the openjfx-dev