RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV
kcr at openjdk.java.net
Wed Feb 26 23:39:20 UTC 2020
On Tue, 25 Feb 2020 13:54:25 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Sorry, mixed up the link with the test unit WIP! :(
>> This is the correct link with the explanatory text related to this suggested fix. Posted  which explains the problem and the suggested solution for discussion.
>>  'Ad suggested fix for "JDK-8234959 FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV"': <https://mail.openjdk.java.net/pipermail/openjfx-dev/2020-February/025102.html>
> @aghaisas can you also review this?
Overall this looks good to me. As I mentioned in PR #123 you should fold that the unit test into this PR.
More information about the openjfx-dev