[Rev 02] RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation
fastegal at openjdk.java.net
Fri Feb 28 17:27:01 UTC 2020
On Fri, 28 Feb 2020 12:14:24 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:
>> Initially I had thought about adding separate test file for RTL - something like RTLTableViewKeyInputTest - but, realized that although it's a cleaner approach, we would simply duplicate the tests. Also, the fact is only LEFT/RIGHT key navigation is sensitive to NodeOrientation - hence only a subset of tests needed modification. This is the reason I have parameterized the test.
>> To your specific question, since it is a parameterized test, only possible values are LTR and RTL which are specified as @Parameterized.Parameters. I don't think, we need additional check for some other value.
> Regarding your suggestion of having forward/backward semantic methods and calling them in tests -
> There are two types of tests -
> 1. Key action remains same - asserts differ based on NodeOrientation
> 2. Key action differs based on NodeOrientation - but, asserts remain same
> Example of 1 is - test_rt18488_selectToLeft
> Example of 2 is - test_rt18591_cell_1
> Your suggestion can be applied only to the tests of type-2. I will try to update tests of this type.
ahh .. okay, missed that difference, thanks :)
Hmm, still feels smelly to have to use the parameter for conditional branches (either on the assumption or on the navigation). Will check later
More information about the openjfx-dev