RFR: 8217472: Add attenuation for PointLight
kcr at openjdk.java.net
Fri Jul 3 13:52:18 UTC 2020
On Wed, 1 Jul 2020 06:31:22 GMT, Nir Lisker <nlisker at openjdk.org> wrote:
>> I would say in addition to rather than instead of, since both are useful.
>> What might help is to add the sphere test plus the pathological test I put together into your test program so we can
>> select between them. And then get a few of us to run that updated program and post results.
> I've added sphere with 10, 64 (default) and 200 divisions. Note that this number is approximate because the sphere mesh
> corrects the division number with `newDivisions = ((oldDivisions + 3) / 4) * 4`.
> [attenTest.zip](https://github.com/openjdk/jfx/files/4855989/attenTest.zip) Using AMD RX 470 4GB on Win 10, all 3
> spheres averaged 120 fps both before and after the patch. (It takes a couple of measurements to hit the consistent fps,
> so I discarded them.)
> If you want these commits to be preserved when you integrate, you will need to make a 'merge-style' pull request.
Please ignore this information from Skara. I don't know what caused it, but I've pinged the Skara folks about it.
> I've added sphere with 10, 64 (default) and 200 divisions.
Thanks, I'll take a look at it.
More information about the openjfx-dev