RFR: 8220484: JFXPanel renders a slanted image with a hidpi monitor scale of 125% or 175% [v4]

Kevin Rushforth kcr at openjdk.java.net
Mon Jul 6 18:27:32 UTC 2020

On Mon, 6 Jul 2020 18:19:53 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Oliver Schmidtmer has refreshed the contents of this pull request, and previous commits have been removed. The
>> incremental views will show differences compared to the previous content of the PR. The pull request contains two new
>> commits since the last revision:
>>  - Similar changes and test for FXCanvas
>>  - more solid test with shim and style independent color
> The test is looking better now. And the fix to `FXPanel` looks correct as well, although needs to be tested.
> I left a few comments relating to the tests. I haven't looked at the SWT test in detail, but will do that later. I also
> still need to test this on multiple platforms (I have a concern about platforms other than Windows due to assumptions
> the test is making).

Also, in general we recommend not to force-push to your branch after the review has started, unless there is some
compelling reason to do so. It makes it harder for reviewers to look at incremental diffs.


PR: https://git.openjdk.java.net/jfx/pull/246

More information about the openjfx-dev mailing list