RFR: 8249777: build.gradle: project.version should not contain time stamps

Joeri Sykora sykora at openjdk.java.net
Thu Jul 23 13:05:20 UTC 2020

On Wed, 22 Jul 2020 17:24:24 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> The addMavenPublication method sets the `project.version` to `$MAVEN_VERSION`, where project is base, graphics,
>> controls, etc. When doing an ordinary "developer" build, this property contains the time stamp . This is causing
>> problems with the NetBeans gradle plugin not being able to determine the dependencies between the projects (modules).
>> We haven't noticed this bug before now, because we suppress the creation of the individual project jar files, but if we
>> were creating them, we would have the problem that each time we ran gradle, it would generate a new
>> `project-$version.jar` file with a different time stamp each time the build was run.  The setting of
>> `project.version=$MAVEN_VERSION` is only used by the maven "publish" tasks, which isn't done for developer builds nor
>> for most productions builds.  The proposed solution is to add a new boolean `MAVEN_PUBLISH` flag, which will default to
>> `false`. This flag will qualify the setting of the `MAVEN_VERSION` property and the configuration of the maven
>> publishing tasks. After this change, it will be necessary to run gradle with `-PMAVEN_PUBLISH=true` in order to run the
>> maven publishing tasks.
> build.gradle line 2063:
>> 2062:     project.ext.moduleName = "javafx.graphics"
>> 2063:     project.ext.mavenPublish = IS_MAVEN_PUBLISH
>> 2064:
> Is this property needed? None of the other projects define it, and I don't see any usage of it.

No, it indeed doesn't seem to be used anywhere. I would remove it.


PR: https://git.openjdk.java.net/jfx/pull/270

More information about the openjfx-dev mailing list