[jfx15] RFR: 8246343: Fix mistakes in FX API docs [v3]
nlisker at openjdk.java.net
Mon Jul 27 21:16:44 UTC 2020
On Mon, 27 Jul 2020 17:32:26 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>> VBox and HBox fixes
> modules/javafx.graphics/src/main/java/javafx/scene/layout/VBox.java line 163:
>> 162: * If no vertical grow priority is set on a child, the vbox will never
>> 163: * allocate it additional vertical space, if available.
>> 164: * <p>
> This isn't a new problem, but the following is awkward:
> "If no vertical grow priority is set on a child, the vbox will never allocate it additional vertical space, if
> If this is trying to say that the vbox will never allocate extra space for that child, then it should be reworded
> slightly. Maybe something like this?
> "If no vertical grow priority is set on a child, the vbox will never allocate any additional vertical space for that
> I note that HBox has the same awkward sentence.
Your suggestion looks good, I tried not to rewrite too much initially.
More information about the openjfx-dev