RFR: 8218973: SVG with masking is not rendering image with mask effect [v6]

Bhawesh Choudhary bchoudhary at openjdk.java.net
Tue Jul 28 17:52:56 UTC 2020

On Fri, 24 Jul 2020 12:10:00 GMT, Arun Joseph <ajoseph at openjdk.org> wrote:

>> Bhawesh Choudhary has updated the pull request incrementally with one additional commit since the last revision:
>>   HiDPI printing and Rendering fix
> modules/javafx.web/src/main/native/Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp line 93:
>> 92:     auto deviceScaleFactor = document().deviceScaleFactor();
>> 93:     maskImageContext.applyDeviceScaleFactor(deviceScaleFactor);
>> 94:
> For javafx port specific code in WebKit, it should be enclosed in `#if PLATFORM(JAVA)`. But I think that there should
> be a better approach as other ports don't require this scaling of `deviceScaleFactor`

RenderSVGResourceMasker.cpp changes are removed now.


PR: https://git.openjdk.java.net/jfx/pull/213

More information about the openjfx-dev mailing list