[Rev 03] RFR: 8244418: MenuBar: IOOB exception on requestFocus on empty bar
fastegal at openjdk.java.net
Tue Jun 16 09:39:42 UTC 2020
On Mon, 15 Jun 2020 11:50:41 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:
>> Issue :
>> Root Cause :
>> Incorrect assumption about menu list size.
>> Fix :
>> Added check for empty menu list before trying to access it.
>> Test :
>> Added a unit test that fails before fix and passes after it.
> Ajit Ghaisas has updated the pull request incrementally with one additional commit since the last revision:
bot says this needs a re-review - here we go: looks fine.
BTW: what we might have learned is to test our test methods as well - if possible :)
Marked as reviewed by fastegal (Author).
More information about the openjfx-dev