RFR: 8214699: Node.getPseudoClassStates must return the same instance on every call [v2]
fastegal at openjdk.java.net
Tue Jun 23 13:22:49 UTC 2020
On Tue, 23 Jun 2020 10:33:05 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:
>> Node.getPseudoClassStates() returns a new UnmodifiableObservableSet of PseudoClassState on each call. So in order to
>> listen to any changes in this set, user must call the method Node.getPseudoClassStates() only once and keep a strong
>> reference to the returned UnmodifiableObservableSet.
>> So the fix is that the method Node.getPseudoClassStates() should return the same UnmodifiableObservableSet on every
>> call. As the returned set is an UnmodifiableObservableSet, it will not have any impact on it's usage.
>> Added a small unit test. and,
>> Altered(minor) a test which was modified in
>> (https://github.com/openjdk/jfx/commit/62323e0a9c5817b33daa262d6914eba0e8d274ff) along with this method and should be
>> updated in view of this change.
> Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision:
> review corrections
looks fine :)
Marked as reviewed by fastegal (Committer).
More information about the openjfx-dev