Integrated: 8214699: Node.getPseudoClassStates must return the same instance on every call
arapte at openjdk.java.net
Tue Jun 23 13:27:41 UTC 2020
On Thu, 18 Jun 2020 16:30:42 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:
> Node.getPseudoClassStates() returns a new UnmodifiableObservableSet of PseudoClassState on each call. So in order to
> listen to any changes in this set, user must call the method Node.getPseudoClassStates() only once and keep a strong
> reference to the returned UnmodifiableObservableSet.
> So the fix is that the method Node.getPseudoClassStates() should return the same UnmodifiableObservableSet on every
> call. As the returned set is an UnmodifiableObservableSet, it will not have any impact on it's usage.
> Added a small unit test. and,
> Altered(minor) a test which was modified in
> (https://github.com/openjdk/jfx/commit/62323e0a9c5817b33daa262d6914eba0e8d274ff) along with this method and should be
> updated in view of this change.
This pull request has now been integrated.
Author: Ambarish Rapte <arapte at openjdk.org>
Stats: 94 lines in 5 files changed: 7 ins; 84 del; 3 mod
8214699: Node.getPseudoClassStates must return the same instance on every call
Reviewed-by: fastegal, kcr
More information about the openjfx-dev