RFR: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts [v6]

Ajit Ghaisas aghaisas at openjdk.java.net
Tue Jun 30 06:03:52 UTC 2020

On Sat, 27 Jun 2020 14:07:24 GMT, Rony G. Flatscher <github.com+60214806+ronyfla at openjdk.org> wrote:

>> This PR adds a "compile" process instruction to FXML files with the optional PI data "true" (default) and "false". The
>> PI data is turned into a boolean value using "Boolean.parseBoolean(String)".
>> This makes it possible to inject the compile PI everywhere in a FXML file and turn on and off compilation of scripts if
>> the scripting engine implements the javax.script.Compilable interface. The PR adds the ability for a fallback in case
>> compilation of scripts fails, in which case a warning gets issued about this fact and evaluation of the script will be
>> done without compilation. Because of the fallback scripts get compiled with this version by default.
>> ---------
>> ### Progress
>> - [x] Change must not contain extraneous whitespace
>> - [x] Commit message must refer to an issue
>> - [ ] Change must be properly reviewed
>> ### Issue
>>  * [JDK-8238080](https://bugs.openjdk.java.net/browse/JDK-8238080): FXMLLoader: if script engines implement
>>    javax.script.Compilable compile scripts
>> ### Download
>> `$ git fetch https://git.openjdk.java.net/jfx pull/192/head:pull/192`
>> `$ git checkout pull/192`
> Rony G. Flatscher has updated the pull request incrementally with one additional commit since the last revision:
>   Incorporating Kevin's review comments (overlooked some places).

Marked as reviewed by aghaisas (Reviewer).


PR: https://git.openjdk.java.net/jfx/pull/192

More information about the openjfx-dev mailing list